-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implied alignment implementation #64
Comments
We'll need to encode an Something like this:
However, this representation will need to be "bit-packed" into the dynamic character stream so that it can be represented by a This representation will take up three times the memory for each dynamic character stream. However, by using this representation we can avoid performing any alignment on the pre-order pass of the tree and instead use a stream processing function to generate the final states. Empirical evidence shows that this results in an asymptotic speed up, resulting in several orders of magnitude less work. Note: We should be able coerce the output from the C code's FFI to this format by zipping over the three aligned sequences and interpreting their results accordingly. |
Note: Turns out that we cannot coerce the output from the C code's FFI to this format. There are alignments which return sequences from which it cannot not be inferred which output elements correspond to which input elements. The implied alignment pre-order code has been added. See this commit: fd49df4. This will be merged into |
As you feared.
|
I came up with a solution to converting the C results to our Haskell data type. I had to modify the In the The The C code is now compatible with the Haskell data-types and the C pairwise alignment returns the same results as the Haskell pairwise alignments. |
Sweet
|
Closing as the implied alignment algorithm has been added (with a defect #166). |
Implement implied alignment algorithm. It's already implement with the old data types. Some type changes are required and simplifying the logic for a post order & pre-order traversal.
The text was updated successfully, but these errors were encountered: