Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize newick string serialization #134

Open
recursion-ninja opened this issue May 18, 2019 · 0 comments
Open

Standardize newick string serialization #134

recursion-ninja opened this issue May 18, 2019 · 0 comments
Assignees
Labels
enhancement low priority minor Likely to take less than 10 hours of work.

Comments

@recursion-ninja
Copy link
Collaborator

There is currently a Newick serialization type-class in pcg-serialize.

We should require that newick serialization place the larger subtree on the right. Additionally, if two subtrees are of equal size, the "lesser" tree should be placed on the left according to the lexicographic ordering of it's leaf labels.

This the convention in phylogenetics. The added benefit is that serialized Newick trees will have a canonical representation, allowing for equality checking of Newick strings.

Some though can be given to expanding this serialization standarization to eNeiwck strings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement low priority minor Likely to take less than 10 hours of work.
Projects
None yet
Development

No branches or pull requests

2 participants