Ensures NullPointerException is not thrown from IonReader.getIntegerSize(). #686
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #686 +/- ##
============================================
- Coverage 67.24% 67.22% -0.02%
- Complexity 5482 5483 +1
============================================
Files 159 159
Lines 23007 23007
Branches 4122 4121 -1
============================================
- Hits 15470 15467 -3
- Misses 6257 6261 +4
+ Partials 1280 1279 -1 ☔ View full report in Codecov by Sentry. |
popematt
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Fixes #685
Description of changes:
Before the change, both the text and binary readers would fail with NPE on the added line 108 of ReaderIntegerSizeTest, where the method is called when the reader is not positioned on a value. The fixes ensure that
nullis returned in this case instead.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.