Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

which package is the maintained one? #24

Open
abubelinha opened this issue Mar 5, 2024 · 3 comments
Open

which package is the maintained one? #24

abubelinha opened this issue Mar 5, 2024 · 3 comments

Comments

@abubelinha
Copy link

abubelinha commented Mar 5, 2024

@alpae you say https://github.com/axiak/fuzzyset/ is no longer maintained
(although the only issue about that was answered by @axiak).

Also, it was updated 8 months ago
(more recently than https://github.com/alpae/fuzzyset fork, last updated 14 months ago).

Both of them point to the same pip package (pip install fuzzyset2)

I find this to be very confusing.
Assuming I made a pip installation, can you both please clarify which repository code should we refer future issues to?

Thanks a lot
@abubelinha

@alpae
Copy link
Owner

alpae commented Mar 5, 2024

Dear @abubelinha

indeed, I forked this repo a few years back from https://github.com/axiak/fuzzyset/ after many months without responded pull-request by the original author. Essentially the library was no longer useable due to outdated numpy versions (I think).

I released the fork on pypi under the name fuzzyset2 after offering to help maintaining: axiak#29 (comment)

A few month later it seems that axiak merged the original pull request (including the changes to fuzzyset2) into his repo. I wasn't aware of this until now.

I'm still maintaining the code in this repo as I'm using it in my own code at several places. Feel free to use it and contribute issues / PR. Cheers Adrian

@abubelinha
Copy link
Author

abubelinha commented Mar 5, 2024

Thanks for your prompt answer, and for providing the link to fixes #28 issue.

I have very low Github/Python knowledge and I don't know how pip packages do relate to source code repositories.
I did not understand how two different repositories can be providing source code for the same pip package (fuzzyset2).

If I understood correctly, that is not happening and your repository is now "the main one", so I suggest to change that fixes #28 issue's title to something more explicit, redirecting people to your repository.
Also, the right "about" section in your repository still links back to the old repo, and that confuses me again
(isn't it enough the top left message where it says "forked from https://github.com/axiak/fuzzyset"?)

About
A simple fuzzy matching set for python strings

github.com/axiak/fuzzyset

So, to be more explicit:

  1. Yesterday, when I did "pip install fuzzyset2", which software did I install? @alpae's or @axiak's code? At that moment, the most recently published version was @axiak's (although I don't know whether that implies a more updated code, or not).
  2. What happens if I run "pip install --upgrade fuzzyset2" command after anyone of you publishes a new version?
    I wonder if I might be unconsciously switching my code from one package to other: how can I print the version of the package my code is using? (so I can tell it is 0.1.3 or 0.2.2).
    (Both of them cite "pip install fuzzyset2" as the proper way to install themselves, although their named versions are quite different: 0.1.3 and 0.2.2 -as of yesterday-)
  3. Probably my confusion arised from here: https://pypi.org/project/fuzzyset/
    The url and package name say fuzzyset but the install section says pip install fuzzyset2. But that is clearly a mistake, isn't it? That command would not install that pip package, but the one in https://pypi.org/project/fuzzyset2/ -which I have discovered just now, by adding "2" to the url-.
  4. I understand future issues should be posted here, in your repo. Can you confirm this?
  5. EDIT: As of now, I see "This branch is 45 commits ahead of, 4 commits behind axiak/fuzzyset:master".
    What does that mean? Both packages contain some functionalities missing in the other package, but on balance your repo is much more evolved? (unless some of those 4 commits are really important)

Thanks again and sorry for the newbie questions

@alpae
Copy link
Owner

alpae commented Mar 6, 2024

if you install fuzzyset2 (pip install fuzzyset2), you install the code from this repo, if you install fuzzyset (pip install fuzzyset), you install the code from @axiak's repo.

Either package you will use in python with import fuzzyset. Codewise, I think both repos are more or less in sync again. The biggest difference is probably that fuzzyset2 contains pre-compiled wheels on pypi, which makes installation easier and faster (especially on windows and macosx).

If I have the time I will try to see with @axiak if we can merge the two versions again. The current situation is clearly not ideal. And yes, feel free to post issues in this repo if you find some problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants