Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Log.type to Log.level #4

Closed
allevo opened this issue May 18, 2024 · 1 comment
Closed

Rename Log.type to Log.level #4

allevo opened this issue May 18, 2024 · 1 comment
Labels
framework Framework core good first issue Good for newcomers

Comments

@allevo
Copy link
Owner

allevo commented May 18, 2024

Commonly the right naming is level for info, debug, error, and so on.
Currently, it is used as a type, and it is not okay.

Tip: https://github.com/allevo/seqflow-js/blob/main/packages/seqflow-js/src/index.ts#L20
@allevo allevo added good first issue Good for newcomers framework Framework core labels May 18, 2024
@allevo
Copy link
Owner Author

allevo commented May 18, 2024

This is not needed anymore. It is replaced by #5

@allevo allevo closed this as completed May 18, 2024
allevo added a commit that referenced this issue Jul 21, 2024
@allevo
Text #4
058346d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
framework Framework core good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@allevo