Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed Parse for Regex Option #8

Closed
simonschoe opened this issue Mar 28, 2020 · 3 comments
Closed

Failed Parse for Regex Option #8

simonschoe opened this issue Mar 28, 2020 · 3 comments

Comments

@simonschoe
Copy link

The Regex option of parse_country is unable to parse the following countries:

  • North Ireland
  • St. Martin
  • Saint Martin
  • Channel Islands
  • Eswatini
@alistaire47
Copy link
Owner

Thanks! Regex are from countrycode, so changes would have to be made there. I haven't rebuild in a while, though, so it's possible [some of] these may already be fixed. I've been meaning to rebuild the data and publish a patch version soon; I'll add an issue for it.

@alistaire47
Copy link
Owner

Rebuild and release is issue #9. If this doesn't solve this issue, one should be opened on countrycode.

@cjyetman
Copy link

Northern Ireland and Saint Martin are not sovereign "countries", so they are unlikely to be included in countrycode. Channel Islands and Eswatini are included in the current CRAN version (v1.1.3).

library(countrycode)

packageVersion('countrycode')
#> [1] '1.1.3'

countrycode('Channel Islands', 'country.name', 'wb')
#> [1] "CHI"

countrycode('Eswatini', 'country.name', 'wb')
#> [1] "SWZ"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants