Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Material Motion library for transitions #149

Open
alisonthemonster opened this issue Oct 17, 2020 · 3 comments
Open

Use Material Motion library for transitions #149

alisonthemonster opened this issue Oct 17, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@alisonthemonster
Copy link
Owner

https://material.io/blog/android-material-motion

This article describes lots of slick transition animations that would be fantastic to add to Presently.

@alisonthemonster alisonthemonster added the enhancement New feature or request label Oct 17, 2020
@polbins
Copy link
Contributor

polbins commented Oct 17, 2020

Hey @alisonthemonster, are you open to migrating the project to Jetpack Compose, then build the animations afterwards?

I heard that animations are way easier in compose and it "might" be easier to take this path in the long term. (I think the project is also a good candidate as it satisfies the minSdk 21 requirement of compose)

@alisonthemonster
Copy link
Owner Author

@polbins Compose is definitely something I'd love to try in Presently! Do you think there's a good candidate for migration? Or do you have a strategy in mind for the migration?

I have yet to dig into compose so I don't know much about what would fit best with our current implementation. Maybe the entry view?

@polbins
Copy link
Contributor

polbins commented Oct 18, 2020

The migration code lab lists down 3 strategies:

  1. Compose in new screens
  2. Compose and Views together
  3. Complete migration (migrate whole fragments or screens, one at a time)

I think it makes sense to go with the 3rd option for smaller screens, and go with the 2nd if ever the screen is too complex.

I'd be glad to try this on the entry fragment! Let me know if I can send a PR for it.
It's a big effort, but I think it would be worth it. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants