Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added README for esbuild package #1416

Merged
merged 7 commits into from
Jan 29, 2025
Merged

Conversation

porhkz
Copy link
Contributor

@porhkz porhkz commented Dec 19, 2024

Description of the proposed changes

Added initial README for esbuild, backwards engineering the definitions from the code. README includes:

  • A description including the purpose of this construct
  • Package name
  • Package version (using badges)
  • Example code
  • Links to esbuild API manual

Screenshots (if applicable)

Other solutions considered (if any)

Notes to PR author

Notes to reviewers

@porhkz porhkz requested review from a team, TheOrangePuff and finnholland and removed request for a team December 19, 2024 02:02
@porhkz porhkz changed the title Chore/do 1759 add readme edbuild Added README for esbuild package Dec 19, 2024
Copy link
Contributor

@TheOrangePuff TheOrangePuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a few minor things

packages/esbuild/README.md Outdated Show resolved Hide resolved
packages/esbuild/README.md Outdated Show resolved Hide resolved
packages/esbuild/README.md Outdated Show resolved Hide resolved
@porhkz porhkz requested a review from TheOrangePuff January 28, 2025 05:19
@porhkz porhkz removed the request for review from finnholland January 29, 2025 01:21
@porhkz porhkz merged commit 8d314f6 into main Jan 29, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants