Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Getting 200 in refresh-token api for empty token #38

Open
coderbdsust opened this issue Jul 22, 2023 · 4 comments
Open

Bug: Getting 200 in refresh-token api for empty token #38

coderbdsust opened this issue Jul 22, 2023 · 4 comments

Comments

@coderbdsust
Copy link

No description provided.

@coderbdsust
Copy link
Author

coderbdsust commented Jul 22, 2023 •
edited
Loading

Screenshot 2023-07-22 at 1 42 18 PM Screenshot 2023-07-22 at 3 54 57 PM

@coderbdsust coderbdsust changed the title Getting 200 in refresh-api from empty token Bug: Getting 200 in refresh-api from empty token Jul 22, 2023
@coderbdsust coderbdsust changed the title Bug: Getting 200 in refresh-api from empty token Bug: Getting 200 in refresh-api for empty token Jul 22, 2023
@coderbdsust coderbdsust changed the title Bug: Getting 200 in refresh-api for empty token Bug: Getting 200 in refresh-token api for empty token Jul 22, 2023
@ali-bouali
Copy link
Owner

can you share more context?
I didn't totally get the issue and you how you got it

@coderbdsust
Copy link
Author

I fixed the issue, now it's look like this.
Screenshot 2023-07-25 at 9 42 14 AM

@ahmadbayan
Copy link

Yes, I had the same issue. I now throw an AuthorizationException, catch it in the controller and set the HTTP response code to 401 for such use cases where the token is missing on the refresh API. Thanks @coderbdsust for sharing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@coderbdsust @ali-bouali @ahmadbayan