--volume-id-in-tag completely broken

[danielbeardsley]

This feature was very useful, but it was broken by 2aff77c

It's broken in two ways:

• We select all snapshots that have the given tag, regardless of its value.
• We AND that with volume_id =

So, if you specify the --volume-id-in-tag TAG option, the list of snapshots is effectively has_tag('TAG') AND volume_id == 'TAG'. It should be one or the other and it should be filtering on tag value, not just presence.

[clewis]

I'm seeing the same thing. I'll have a PR shortly.

[clewis]

@danielbeardsley , can you try out #30 ?