Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve /about/executions endpoint #494

Open
MHHukiewitz opened this issue Nov 30, 2023 · 0 comments
Open

Improve /about/executions endpoint #494

MHHukiewitz opened this issue Nov 30, 2023 · 0 comments

Comments

@MHHukiewitz
Copy link
Member

The current implementation in lines 143-144 of #490:

return {
    "process": pid_info,
    **self.__dict__,
}

poses a risk of unintentionally overriding process data, as pointed out by @MHHukiewitz. This approach could lead to data loss or manipulation. @olethanh, while concerned about database compatibility, also notes irrelevant data appearing in the /about/executions endpoint. @hoh is open to improvements.

A revision is suggested to prevent potential data integrity issues and clean up the endpoint's output, possibly by introducing a separate field for self.__dict__. This aims to balance maintaining existing functionality with ensuring robust data handling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant