Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ALEPH-126 - Upgrade pydantic version #108

Closed
RezaRahemtola opened this issue Sep 13, 2024 · 2 comments · Fixed by #110
Closed

ALEPH-126 - Upgrade pydantic version #108

RezaRahemtola opened this issue Sep 13, 2024 · 2 comments · Fixed by #110
Assignees

Comments

@RezaRahemtola
Copy link

RezaRahemtola commented Sep 13, 2024

The current version of pydantic used is <2.0.0, while the 2.0 has been out for more than a year now (in fact we are at v2.9.1 atm).

This means that for newly created projects, installing pydantic then aleph-sdk-python (that depends on aleph-message) throws an error and forces the user to downgrade their pydantic version, which might be problematic (not in this specific case for me, but at LibertAI we have our agents framework that requires features of pydantic v2, so people won't be able to use it with the aleph-sdk)
image

@RezaRahemtola
Copy link
Author

cc @philogicae @hoh

@hoh
Copy link
Member

hoh commented Sep 16, 2024

The main motivation for staying on pydantic 1 was that it was the version packaged on Debian stabe.

I believe that given the additional constraints we have now, aleph-message should either be made compatible with both versions or aleph-vm should vendor pydantic 2.

@Antonyjin Antonyjin self-assigned this Sep 19, 2024
@Psycojoker Psycojoker changed the title Upgrade pydantic version ALEPH-126 - Upgrade pydantic version Sep 19, 2024
@Antonyjin Antonyjin linked a pull request Oct 2, 2024 that will close this issue
@hoh hoh closed this as completed in #110 Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants