New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validateRequest - minor bug ? #117

Open

alanbontoft opened this issue Dec 3, 2024 · 0 comments

alanbontoft commented Dec 3, 2024

In the function validateRequest, should this line (case MB_FC_WRITE_REGISTER) :-

        if (u16AdRegs > modH-> u16regsize) return EXC_ADDR_RANGE;

actually use the >= operator ?

e.g. you should only be able to write to a maximum index of u16regsize - 1

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment