Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer Review Assignment 4 #168

Open
gattur opened this issue Apr 25, 2019 · 5 comments
Open

Peer Review Assignment 4 #168

gattur opened this issue Apr 25, 2019 · 5 comments

Comments

@gattur
Copy link

gattur commented Apr 25, 2019

Please update Wiki

@gattur
Copy link
Author

gattur commented Apr 25, 2019

please update release instructions

@aravindparappil46
Copy link

@gattur We have updated the Wiki (apart from the architecture diagram). Sorry for the delay. Instructions have been updated and you can go ahead and test this milestone. Will be updating the diagram soon.

@gattur
Copy link
Author

gattur commented Apr 26, 2019

Hi Team,
Great Job! , application looks super nice, especially the previous song history.
As mentioned in the previous issues.

  1. Signup is not working.
  2. it will be nice if the song starts playing upon the click.

few suggestions.

1 . it would be nice if the search can provide auto complete suggestions, i think spotify could help with that.
https://community.spotify.com/t5/Closed-Ideas/Auto-complete-search-field-and-suggestion-list-google-search/idi-p/769635
2 . when we signup with utopia, is there any reason why is mandatory login to spotify. are you guys using any history from the spotify usage history or to accept spotify agreement. can spotify login be removed.

Thanks,
Gattu

@aravindparappil46
Copy link

Thanks for the suggestions, @gattur Will definitely take them into consideration
The spotify login is required to auhorize the app to hit the Spotify APIs. Essentially, we should be able to keep only 1 level of login, as the ideal case.

@sairohithA007
Copy link
Contributor

@gattur the signup issue is fixed. Please refer #186 for more information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants