Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: show image tag in aiidalab-launch status. #67

Open
yakutovicha opened this issue Jan 25, 2022 · 3 comments
Open

Enhancement: show image tag in aiidalab-launch status. #67

yakutovicha opened this issue Jan 25, 2022 · 3 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@yakutovicha
Copy link
Member

To have a quick overview of what is going on, I think it is a good idea to show the image tag in aiidalab-launch status. Even though it is already shown in aiidalab-launch profiles show <profile_name>.

@yakutovicha yakutovicha added the enhancement New feature or request label Jan 25, 2022
@csadorf
Copy link
Member

csadorf commented Feb 1, 2022

Would you expect it to be of the form aiidalab/aiidalab-docker-stack:latest for the running container? We could try this, however be aware, that this might not be 100% well defined since the image might have changed since you started the container and the same image can also be tagged in different ways.

My other concern is that this would make the status output extremely wide.

@csadorf csadorf added the question Further information is requested label Feb 9, 2022
@yakutovicha
Copy link
Member Author

Would you expect it to be of the form aiidalab/aiidalab-docker-stack:latest for the running container?

Personally, I would prefer to have something like this:

Profile    Container         Status    Mount                        Image                           Tag     URL
---------  ----------------  --------  ---------------------------  ------------------------------  ------  ---------------------------------------------------------------------------------------------
default    aiidalab_default  up        /Users/yakutovicha/aiidalab  aiidalab/aiidalab-docker-stack  latest  http://localhost:8888/?token=....

We could try this, however be aware, that this might not be 100% well defined since the image might have changed since you started the container and the same image can also be tagged in different ways.

Hmm, indeed, it looks like the only information one could reliably get is the image's sha and the name. Getting the tag seems not to be easy. At the same time, the tag that has been requested is known from the config. To avoid confusion, we might want to call it not just "Tag", but "Requested Tag" or similar:

Profile    Container         Status    Mount                        Image                           Requeted Tag  URL
---------  ----------------  --------  ---------------------------  ------------------------------  ------------  ---------------------------------------------------------------------------------------------
default    aiidalab_default  up        /Users/yakutovicha/aiidalab  aiidalab/aiidalab-docker-stack  latest        http://localhost:8888/?token=......

My other concern is that this would make the status output extremely wide.

True. We might want to leave the things to be displayed configurable, so the user can decide what to show. Like --tag/--no-tag to display the tag, -a to display everything. But at this point it feels like I am overcomplicating things 😅.

@csadorf
Copy link
Member

csadorf commented Feb 17, 2022

I think the option to show the Image tag is most important to developers and not so much to users. For users it is much more important that the URL is shown in full to be able to easily open it in the browser. I would be open to showing the tag as part of a --wide status view. Please let me know if you would like to implement this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants