-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notify user when new image is available #188
Comments
This is a useful feature but not clear to me the definition of "new image". |
Ah, indeed, I meant the second case. First case doesn't make much sense, since we can't know which new tags are available (at least not easily). |
I did have a look at the link you shared https://hynek.me/articles/semver-will-not-save-you/ (Not very happy at beginning of the reading as well, but being persuaded a bit after) and come back to this issue, I am now understand the docker image release strategy of Jupyter docker stack that they running the released CI periodically. I didn't adopt this setting when I refactoring the CI workflow. |
I am not sure what you mean here. But for a given profile, we now both the image and its tag, so we should hopefully be able to reuse the existing download logic to check if newer image is available when the user starts the container. No need to look at all tags. |
In #184 we've changed the default behaviour so that the new AiiDAlab docker image is pulled only when user explicitly requests it. This is good for stability, but now users are not aware of updates. We should print a note when a new Docker image becomes available when the user tries to start a container.
The text was updated successfully, but these errors were encountered: