handling errors properly #62
Conversation
| if (!/\.(pug|jade)/.test(path.extname(file))) { | ||
| return | ||
| } | ||
| try { |
There was a problem hiding this comment.
only wrap the actual pug calls, not the whole logic block.
There was a problem hiding this comment.
Yeah that was my initial approach too.
Buuut, the nice thing about throw is that it "breaks" forEach like break does with a classic loop.
Hence I decided to wrap the whole block.
Otherwise we would need to accumulate errors in an array...
There was a problem hiding this comment.
Well, I prefer to bail-out on first error, but I can quickly change it to try all files.
| files[name] = data | ||
| }) | ||
|
|
||
| setImmediate(done) |
There was a problem hiding this comment.
can just call done() instead of using setImmediate given the new direction
There was a problem hiding this comment.
nope, setImmediate let's other i/o operations taking place before calling the next metalsmith plugin. see: https://nodejs.org/api/timers.html#timers_setimmediate_callback_args
|
need to add a test as well. |
|
here you go, a simple test to check if |
|
@ahmadnassri |
fixes #61