Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding transaction_id, subscription_id as part of standard response dictionary #19

Open
tinio opened this issue Nov 8, 2011 · 2 comments
Assignees

Comments

@tinio
Copy link

tinio commented Nov 8, 2011

Given that the various payment processor gateways have widely varying transaction response objects, it would be incredibly helpful to include 'transaction_id' and 'subscription_id' as part of the standard response dictionary.

As an example, here's the implementation for the authorize.net gateway: tinio/merchant@5595448

@theju, if this sounds agreeable and doesn't go against a possible desire to keep the standard response dictionary simple, I'd be happy to implement this for additional gateways, and submit a proper Pull Request.

Thanks.

@theju
Copy link
Contributor

theju commented Nov 8, 2011

@tinio, I am fine with your request but certain gateways don't send a transaction_id if the transaction fails. Let me check with all the gateways we have implemented so far.

@tuxcanfly
Copy link
Member

Instead of another item in the dictionary, it would be better to have a standard response object, in my opinion. The current response abstraction is leaky - it leaks the backend response class instance.

Will need to go through the responses, filter out the common attributes and consolidate them into a single class. If it's possible at all..

@ghost ghost assigned tuxcanfly May 14, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants