Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Attempt download over https, even if url is given as http in feed #3818

Closed
ImmanuelMc opened this issue Jan 10, 2025 · 4 comments
Labels
enhancement New feature or request

Comments

@ImmanuelMc
Copy link

Type of Enhancement

Server Backend

Describe the Feature/Enhancement

Attempt to download podcast episodes via https when the url is given as http. And fallback to http if that fails.

Why would this be helpful?

On a few long running rss feeds I am subscribed to, old links were never updated to https, but server security policy must have changed to refuse http connections. This is technically an issue with the feed, but if there isn't a concern with attempting https connections, it would allow continuing to download old episodes even if the feed is not fixed.

Future Implementation (Screenshot)

This isn't a ui suggestion.

Audiobookshelf Server Version

2.17.7

Current Implementation (Screenshot)

No response

@ImmanuelMc ImmanuelMc added the enhancement New feature or request label Jan 10, 2025
@advplyr
Copy link
Owner

advplyr commented Jan 10, 2025

You can change the feed URL of the podcast then use the quick match all episodes feature in the context menu of the episode list

@ImmanuelMc
Copy link
Author

I have changed the feed URL. Inside the feed, links to older episodes point to http://feeds.soundcloud.com, newer episodes point to https://feeds.soundcloud.com . The feed url is https://www.filmreroll.com/?feed=podcast . It switches from http to https at episode 81. I have contacted them about the issue, so they may update the urls in the meantime, but I have run into this issue on other feeds with old content.

When navigating to the old download link in a browser it is automatically redirected to https, which seems like what is supposed to happen with HSTS, but it is not my field so I am not sure.

@advplyr
Copy link
Owner

advplyr commented Jan 15, 2025

I'm able to download the oldest episodes and the newest episodes for that podcast fine. Are you getting an error when you download?

@advplyr advplyr added the waiting Waiting for OP label Jan 15, 2025
@ImmanuelMc
Copy link
Author

This appears to be an issue with my network. In testing with wget/curl I am getting connection refused instead of a 301 response, from every site using 301 redirects to https that I have tried, from multiple computers on my network using different OSes. The same wget/curl commands do work when tested on machines not on my network. So I think this can be closed.

@advplyr advplyr closed this as not planned Won't fix, can't repro, duplicate, stale Jan 16, 2025
@advplyr advplyr removed the waiting Waiting for OP label Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants