-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement]: Handle Podcast RSS feed that isn't using CDATA for description fields #3778
Comments
Looks like it specifically due to one of the episode descriptions being parsed as an object instead of a string. From that RSS feed: |
Yeah I think it is invalid XML but I'm not an XML expert. When using HTML tags it should be wrapped in CDATA |
For what it's worth, it looks like valid xml to me (I am a .net dev in my dat job that deals with too much xml). I am not super familiar with the js/node/vue environment, but is there any schema that backs deserializing an rss feed? If there was some kind of xsd that this can run against, then this whole thing shouldn't be an issue. That said if this was a perfect world I would agree that this is on the publisher to fix. |
Could probably just do something silly and say "if an object, strinigify" for descriptions and titles. It would render weird, but then it could at least be imported. We would probably then get bug reports about that, though... |
That gets my vote. Can probably even pit some kind of warning on the podcast page that says there may be iasues with the title/description if you do need to call stringify. |
Fixed in v2.18.0. |
What happened?
I attempted to add an RSS feed (https://gorkyr.github.io/We-Want-MoR-Playlist/we-want-mor.rss) to my podcasts library, but ran into an error (log is pasted below)
What did you expect to happen?
Successfully add a podcast
Steps to reproduce the issue
Audiobookshelf version
v2.17.7 and v2.17.6
How are you running audiobookshelf?
Docker
What OS is your Audiobookshelf server hosted from?
Linux
If the issue is being seen in the UI, what browsers are you seeing the problem on?
Firefox
Logs
Additional Notes
No response
The text was updated successfully, but these errors were encountered: