Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking changes in 1.4.x #380

Open
jaswilli opened this issue Nov 22, 2021 · 2 comments
Open

Breaking changes in 1.4.x #380

jaswilli opened this issue Nov 22, 2021 · 2 comments

Comments

@jaswilli
Copy link
Contributor

jaswilli commented Nov 22, 2021

Just a heads-up that moving utils/object-transform.js and utils/remove-from-dom.js into a -private namespace and removing the re-exports should likely have been considered a breaking change since for all intents and purposes they were public and apps could reasonably be relying upon them. For example, if you wanted to override trackEvent() in an adapter and use object-transforms#compact.

Probably nothing to be done about it at this point, just opened this for awareness that there may be some broken downstream consumers. Feel free to close!

Also, thanks for spending the time keeping this addon maintained and up-to-date!

@jherdman
Copy link
Contributor

You're right, my apologies for that.

I'll keep this issue open for a few days just in case there are a few other affected consumers. If it's bad enough I'll revert those changes.

@jherdman
Copy link
Contributor

jherdman commented Dec 8, 2021

I'm going to revert this, but leave -private in so there's not too much thrash. v2 will remove -private. What a mess!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants