You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Just a heads-up that moving utils/object-transform.js and utils/remove-from-dom.js into a -private namespace and removing the re-exports should likely have been considered a breaking change since for all intents and purposes they were public and apps could reasonably be relying upon them. For example, if you wanted to override trackEvent() in an adapter and use object-transforms#compact.
Probably nothing to be done about it at this point, just opened this for awareness that there may be some broken downstream consumers. Feel free to close!
Also, thanks for spending the time keeping this addon maintained and up-to-date!
The text was updated successfully, but these errors were encountered:
Just a heads-up that moving
utils/object-transform.js
andutils/remove-from-dom.js
into a-private
namespace and removing the re-exports should likely have been considered a breaking change since for all intents and purposes they were public and apps could reasonably be relying upon them. For example, if you wanted to overridetrackEvent()
in an adapter and useobject-transforms#compact
.Probably nothing to be done about it at this point, just opened this for awareness that there may be some broken downstream consumers. Feel free to close!
Also, thanks for spending the time keeping this addon maintained and up-to-date!
The text was updated successfully, but these errors were encountered: