Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makeinstancesufo should not rely on lib copy=1 key #1764

Open
frankrolf opened this issue Nov 19, 2024 · 0 comments
Open

makeinstancesufo should not rely on lib copy=1 key #1764

frankrolf opened this issue Nov 19, 2024 · 0 comments

Comments

@frankrolf
Copy link
Member

frankrolf commented Nov 19, 2024

(Carrying over from a discussion on the RoboFont discord)

Using the current designspaceLib, it’s possible to use findDefault() to identify the default source.
https://fonttools.readthedocs.io/en/latest/designspaceLib/python.html#fontTools.designspaceLib.DesignSpaceDocument.findDefault

This implies that the XXX copy=1 keys are not necessarily set in modern .designspace files.
As a result, instance UFOs produced with makeinstancesufo may end up with scrambled glyph order.

I don’t see a scenario in which an instance built via makeinstancesUFO should not inherit the groups.plist/lib.plist from the default source UFO. I’d argue for these to always be transferred.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant