Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[buildcff2vf] assumes OS/2 table of default source #1578

Open
frankrolf opened this issue Nov 25, 2022 · 2 comments
Open

[buildcff2vf] assumes OS/2 table of default source #1578

frankrolf opened this issue Nov 25, 2022 · 2 comments

Comments

@frankrolf
Copy link
Member

After merging sources with “naturally created” (through makeotf) usWinAscent values, I noticed (via FontBakery output) that the OS/2 values written into the VF just correspond to the values found in the default source.

Should this happen? Or should cff2vf perhaps have a “bounding box of all sources” calculation?

@skef
Copy link
Collaborator

skef commented Nov 25, 2022

In theory usWinAscent values should be blended like many other VF values, with the value corresponding to the default master going into the OS_2 table and the other data going into MVAR under the hcla tag. So there could be three (most likely) problems here:

  1. The sources all have the same usWinAscent value so there's nothing to blend and put into the MVAR entry. (It sounds like you've confirmed this isn't what's happening.)
  2. The other values are being discarded rather than blended into an MVAR entry.
  3. FontBakery is just showing the value from the table and not taking the MVAR entry into account.

@frankrolf
Copy link
Member Author

This is what the VF in question has in its MVAR table, for the hcla tag:

    <ValueRecord index="0">
      <ValueTag value="hcla"/>
      <VarIdx value="1"/>
    </ValueRecord>

In other words – not much?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants