-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[buildmasterotfs/buildcff2vf] only works for UFOs without processed layer #1154
Comments
An additional thought I just had about this – any hinting information is present in the processed layer. How would that info make it into a variable CFF2 in a potential future workflow? |
The UFO masters would have to have that data in the foreground layer as well. By default the hinting data is added to the processed layer, but psautohint has an option for not doing that. |
Would there be a way to force |
This fell on my feet once again. If there was a way to make |
Encountered today by @ibo-o – as far as I can tell, it was a waste of time to figure out the problem. |
Looking at this I'm wondering what the specific problem is. If So it seems like the issue here isn't necessarily that Maybe the right solution for this is to use the layer name |
The problem is that To make this process more bulletproof, |
This change would be equivalent to saying that you can't hint the glyphs in a variable font before building it. So we should be sure that's OK and not needed for, e.g., CJK fonts. |
Definitely doesn't matter for our CJK fonts now. We aren't hinting the variable fonts yet and even if we will in the future it will be after the VF build. |
Maybe we can add a switch that says to use the processed layer but default to the foreground, which should take care of 99% of the problem assuming people don't want to pre-hint their sources. |
I have a feeling we’re discussing the same problem from two different perspectives. I understand Skef’s concern from a future standpoint – but right now, it’s just too easy to try and merge incompatible sources. This all calls for the replacement of the 2-step workflow – maybe with a tool which will be able to hint sources on the fly, and merge those hinted VFs – without leaving tons of data in the UFO files. |
The only benefit of hinting "before" rather than "after" is that you can do it once and then rebuild multiple times. So there isn't much benefit to hinting in the middle versus after the font is built. |
Currently, our CFF2 VF building workflow is split in two steps –
buildmasterotfs
(to build dummy OTF files from UFO masters), andbuildcff2vf
(to merge these OTFs into a Variable CFF2).I think it is problematic is that
buildmasterotfs
quietly requires master UFOs without aglyphs.com.adobe.type.processedglyphs
layer – otherwise the VF merging in step 2 will fail because of outline incompatibilities.I wonder if there could be a way to make
buildmasterotfs
independent of the processed layer. Sincebuildmasterotfs
just wrapsmakeotf
, this would require adding an “prefer foreground layer” option there.The text was updated successfully, but these errors were encountered: