From 7cd7519ef1eba7efe9cc30f3ca8606dd9807260b Mon Sep 17 00:00:00 2001 From: Skef Iterum Date: Tue, 5 Nov 2024 14:21:02 -0800 Subject: [PATCH] Try going back to C++11 to see if errors change --- .github/workflows/testpythonpackage.yml | 5 +++-- CMakeLists.txt | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/testpythonpackage.yml b/.github/workflows/testpythonpackage.yml index c5a6fd033..db5a3a1a5 100644 --- a/.github/workflows/testpythonpackage.yml +++ b/.github/workflows/testpythonpackage.yml @@ -27,7 +27,8 @@ jobs: runs-on: ${{ matrix.os }} strategy: matrix: - os: [ubuntu-latest, macos-latest, windows-latest] + # os: [ubuntu-latest, macos-latest, windows-latest] + os: [windows-latest] python-version: ["3.9", "3.10", "3.11", "3.12"] exclude: - os: macos-latest @@ -64,7 +65,7 @@ jobs: if: matrix.os == 'windows-latest' uses: microsoft/setup-msbuild@v1.3 with: - vs-version: '[17.0,17.10]' + vs-version: '[17.0,]' msbuild-architecture: x64 - name: Set Windows generator to Visual Studio diff --git a/CMakeLists.txt b/CMakeLists.txt index 49b959355..88e9cfd0c 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -18,7 +18,7 @@ if (NOT CMAKE_BUILD_TYPE) endif() message(STATUS "Build type is ${CMAKE_BUILD_TYPE}") -set(CMAKE_CXX_STANDARD 17) +set(CMAKE_CXX_STANDARD 11) # scikit-build if(SKBUILD)