Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How do we merge this with adhearsion-asr / Adhearsion core? #3

Open
benlangfeld opened this issue Mar 12, 2014 · 2 comments
Open

How do we merge this with adhearsion-asr / Adhearsion core? #3

benlangfeld opened this issue Mar 12, 2014 · 2 comments
Labels

Comments

@benlangfeld
Copy link
Member

Adhearsion-asr cannot be merged into Adhearsion core until Adhearsion 3.0 since it changes the API of core #ask and #menu methods on CallController.

Particularly #menu is a candidate for closer integration with this gem.

@benlangfeld
Copy link
Member Author

So, it's plausible that we could merge some parts of adhearsion-asr into Adhearsion core prior to Adhearsion 3.0: the settings, the PromptBuilder and the Result structure. We could not include the #ask and #menu controller methods, since they are the parts which are not backward compatible. There would not be a benefit to including either the AskGrammarBuilder (used to build grammars from :limit options to #ask) or the MenuBuilder (implementing the menu DSL, including grammar construction from #matches, retries, error/failure handling and invocation of #matches).

Merging these pieces into Adhearsion core would reduce the future effort required to merge adhearsion-asr into core, allow adhearsion-ivr to function without depending on adhearsion-asr, and thus allowing adhearsion-ivr to be merged in to core in the Adhearsion 2.x series, if this were desirable.

@benlangfeld
Copy link
Member Author

Additionally, in its current form, this gem provides similar functions to #ask. What it does not provide from adhearsion-asr is simple support for built-in grammars for common cases (from #ask, eg yes/no, DTMF grammars with digit limits or unlimited input up to a terminator) or automatic grammar construction from a list of possible options (from #menu, similar to VoiceXML Menus).

These features do not help the case for a merge into Adhearsion core, but would permit absorbing adhearsion-asr such that #ask and #menu might be deprecated entirely from Adhearsion core and maintained solely in adhearsion-asr, should we decide that this whole-controller implementation was preferable going forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant