Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The server crashes #10

Open
leedstark opened this issue Aug 14, 2017 · 8 comments
Open

The server crashes #10

leedstark opened this issue Aug 14, 2017 · 8 comments

Comments

@leedstark
Copy link

VSCode said the server crashed 5 times in 3 minutes. It won't be started again.

@adamvoss
Copy link
Owner

Thank you for reporting this. To fix this it will help to know more about the issue. When this happens, there should be a stack trace and exception information under Output (CTRL+K CTRL+H). Could you provide the information from there? Also if you know how to cause this issue, that would help me to find the issue and test a fix.

@lee-baker
Copy link

lee-baker commented Sep 1, 2017

I get this issue also, it happens as soon as I open a YAML file.

The output is

[Info - 1:51:07 pm] Connection to server got closed. Server will restart.
enable
Unsupported feature, node kind: 5
C:\Users\Lee.vscode\extensions\adamvoss.yaml-0.0.8\server\node_modules\vscode-yaml-languageservice\lib\parser\yamlParser.js:138
valueNode.location = key.value;
^

TypeError: Cannot set property 'location' of undefined
at recursivelyBuildAst (C:\Users\Lee.vscode\extensions\adamvoss.yaml-0.0.8\server\node_modules\vscode-yaml-languageservice\lib\parser\yamlParser.js:138:36)
at recursivelyBuildAst (C:\Users\Lee.vscode\extensions\adamvoss.yaml-0.0.8\server\node_modules\vscode-yaml-languageservice\lib\parser\yamlParser.js:124:40)
at createJSONDocument (C:\Users\Lee.vscode\extensions\adamvoss.yaml-0.0.8\server\node_modules\vscode-yaml-languageservice\lib\parser\yamlParser.js:211:21)
at yamlDocs.map.doc (C:\Users\Lee.vscode\extensions\adamvoss.yaml-0.0.8\server\node_modules\vscode-yaml-languageservice\lib\parser\yamlParser.js:255:53)
at Array.map (native)
at Object.parse (C:\Users\Lee.vscode\extensions\adamvoss.yaml-0.0.8\server\node_modules\vscode-yaml-languageservice\lib\parser\yamlParser.js:255:42)
at Object.parseYAMLDocument (C:\Users\Lee.vscode\extensions\adamvoss.yaml-0.0.8\server\node_modules\vscode-yaml-languageservice\lib\yamlLanguageService.js:65:59)
at C:\Users\Lee.vscode\extensions\adamvoss.yaml-0.0.8\server\out\yamlServerMain.js:232:117
at Object.get (C:\Users\Lee.vscode\extensions\adamvoss.yaml-0.0.8\server\out\languageModelCache.js:34:33)
at getJSONDocument (C:\Users\Lee.vscode\extensions\adamvoss.yaml-0.0.8\server\out\yamlServerMain.js:240:26)

@adamvoss
Copy link
Owner

adamvoss commented Sep 1, 2017

Thanks @lee-baker, that is very helpful!

Unsupported feature, node kind: 5

Node kind 5 means an include reference which are documented in the README as not supported. It would be better if they didn't crash the whole server though. That said, it might not be a whole lot more work to just add support for support rather than adding better failure behavior.

@ferdydek
Copy link

Oddly the same happens with YAML Support by Red Hat

@TheMasquerader
Copy link

I have the same problem.
My setup specs:

  • Windows 10
  • VSCode:
    -- Version 1.20.1
    -- Commit f88bbf9137d24d36d968ea6b2911786bfe103002
    -- Date 2018-02-13T15:34:36.336Z
    -- Shell 1.7.9
    -- Renderer 58.0.3029.110
    -- Node 7.9.0
    -- Architecture x64
  • YAML for VS Code 0.0.10

The error in the Output is:

C:\Users\Atodic\.vscode\extensions\adamvoss.yaml-0.0.10\server\node_modules\vscode-json-languageservice\lib\services\jsonValidation.js:47
            jsonDocument.syntaxErrors.forEach(addProblem);
                                     ^

TypeError: Cannot read property 'forEach' of undefined
    at JSONValidation.doValidation (C:\Users\Atodic\.vscode\extensions\adamvoss.yaml-0.0.10\server\node_modules\vscode-json-languageservice\lib\services\jsonValidation.js:47:38)
    at yamlDocument.documents.map.d (C:\Users\Atodic\.vscode\extensions\adamvoss.yaml-0.0.10\server\node_modules\vscode-yaml-languageservice\lib\yamlLanguageService.js:48:71)
    at Array.map (native)
    at Object.doValidation (C:\Users\Atodic\.vscode\extensions\adamvoss.yaml-0.0.10\server\node_modules\vscode-yaml-languageservice\lib\yamlLanguageService.js:48:62)
    at validateTextDocument (C:\Users\Atodic\.vscode\extensions\adamvoss.yaml-0.0.10\server\out\yamlServerMain.js:215:21)
    at Timeout._onTimeout (C:\Users\Atodic\.vscode\extensions\adamvoss.yaml-0.0.10\server\out\yamlServerMain.js:205:9)
    at ontimeout (timers.js:386:14)
    at tryOnTimeout (timers.js:250:5)
    at Timer.listOnTimeout (timers.js:214:5)
[Error - 9:06:05 AM] Connection to server got closed. Server will not be restarted.

Thank you!

@emman27
Copy link

emman27 commented Mar 2, 2018

Getting the exact same error as @TheMasquerader

@xujihui1985
Copy link

this issue has been opened over year, and this problem still not fixed

@will-l-h
Copy link

Use the yaml extension by redhat. It's maintained and this issue had been fixed on it.

https://marketplace.visualstudio.com/items?itemName=redhat.vscode-yaml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants