Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document outlining is finding no results #7

Open
JPinkney opened this issue Sep 15, 2017 · 4 comments
Open

Document outlining is finding no results #7

JPinkney opened this issue Sep 15, 2017 · 4 comments

Comments

@JPinkney
Copy link

I'm getting null as my result for languageService.findDocumentSymbol(document, jsonDocument). I've tried using this service through your vscode extension and through the vscode-yaml-languageservice directly but have not been able to get it to work

@adamvoss
Copy link
Owner

Thanks for reporting this! Just tried Ctrl + Shift + o in vscode and confirm. This is regression. Admittedly I have not tested this since pre-0.1 and unfortunately this is not one of the methods covered by the automated tests.

@rcjsuen
Copy link

rcjsuen commented Jan 12, 2018

@JPinkney Is this still a problem? I built and used yaml-language-server in a Monaco editor and symbols did seem to show up for me.

Given that the tests in documentSymbols.test.ts are also passing it seems to me like this isn't a problem anymore?

@JPinkney
Copy link
Author

I decoupled the document outlining part from vscode-yaml-languageservice a while ago. We do still rely on this for a few things (I can't remember off the top of my head) but validation, document outlining etc are all provided on their own inside redhat-developer/yaml-language-server.

@rcjsuen
Copy link

rcjsuen commented Jan 12, 2018

Oh. Well don't I look like a fool then. Thanks for clarifying! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants