Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Join and Split operations with "Change" (or whatever) #31

Open
adammck opened this issue Dec 20, 2022 · 0 comments
Open

Replace Join and Split operations with "Change" (or whatever) #31

adammck opened this issue Dec 20, 2022 · 0 comments
Labels
maybe refactor Something to change.

Comments

@adammck
Copy link
Owner

adammck commented Dec 20, 2022

I started with a single reshard operation, which took an arbitrary number of adjacent ranges and splits as inputs, and output a new set of adjacent ranges. But it proved too hard to implement, because basically nothing worked back then. So I replaced it with separate Join/Split ops.

But now things do mostly work, and there's a bunch of pointless divergence between Join and Split, which are actually the same thing. Maybe the terminology should stay, because it's obvious what "Split a range" means, but the implementation should be re-unified and called something.

@adammck adammck added refactor Something to change. maybe labels Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maybe refactor Something to change.
Projects
None yet
Development

No branches or pull requests

1 participant