Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python-hydra-core] uses antlr 4.9.3 while python-antlr4 is 4.11.1-1 #212

Open
4rozenwolves opened this issue Oct 19, 2022 · 4 comments
Open
Labels
enhancement New feature or request patched

Comments

@4rozenwolves
Copy link

Hydra uses an internal antlr.

This makes it not compatible with antlr installed in the system. One solution is to replace the internal antlr to use system antlr, as done in python-omegaconf.

@4rozenwolves
Copy link
Author

I added the following code in the pkgbuild:

prepare() {
  cd "${srcdir}/${_pkgname}-${pkgver}"
  sed -i 's/join(root_dir, "bin\/antlr-4.9.3-complete.jar")/"\/usr\/share\/java\/antlr-complete.jar"/' 'build_helpers/build_helpers.py'
}

@acxz
Copy link
Owner

acxz commented Feb 22, 2023

Personally, I believe that if upstream wants to use their own packaged antlr4, then as packagers we should respect that (assuming that there are no other issues due to that decision). If someone could make an upstream issue that requests the option to use system installed antlr4 then we can get the reception of upstream to see if they would be open to that.

@acxz acxz changed the title python-hydra-core uses antlr 4.9.3 while python-antlr4 is 4.11.1-1 [python-hydra-core] uses antlr 4.9.3 while python-antlr4 is 4.11.1-1 Feb 22, 2023
@acxz acxz added the patched label Feb 22, 2023
@acxz
Copy link
Owner

acxz commented Feb 22, 2023

patched with #223

@acxz
Copy link
Owner

acxz commented Mar 28, 2023

keeping this open until the patch is no longer needed

@acxz acxz reopened this Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request patched
Projects
None yet
Development

No branches or pull requests

2 participants