GetItemOffersBatch seems to be broken with the 1.7.34 update

[lboyarsky]

Hi,

My code is calling GetItemOffersBatchAsync in a loop. It used to work fine, but since the 1.7.34 update, it hangs after the first successful call. When I enable debug mode, I can see what appears to be an infinite loop:

[...]
Attempting to increment tokens
0 tokens to replenish since 12/30/2024 12:38:13 AM
Attempting to increment tokens
0 tokens to replenish since 12/30/2024 12:38:13 AM
Attempting to increment tokens
0 tokens to replenish since 12/30/2024 12:38:13 AM
Attempting to increment tokens
0 tokens to replenish since 12/30/2024 12:38:13 AM
Attempting to increment tokens
0 tokens to replenish since 12/30/2024 12:38:13 AM
Attempting to increment tokens
0 tokens to replenish since 12/30/2024 12:38:13 AM
[...]

It seems the rate limiting was refactored in the latest version, which might be causing this issue.

Rolling back to the previous version resolves the problem.

[FinnReilly]

Hi - I've done a quick investigation into this, and it looks as though the ProductPricing_GetItemOffersBatch rate limit type is hardcoded with the following parameters - new RateLimits(0.1M, 1, RateLimitType.ProductPricing_GetItemOffersBatch).

Unless I interpreted the RateLimits type incorrectly in my code, this means that tokens are added to the bucket at a rate of 0.1 per second with a maximum quantity (burst rate) of 1. This would appear to translate into one request being permitted every 10 seconds. @lboyarsky please could you confirm whether requests are being permitted at this rate?

If so then potential fixes would be changing this configuration or (better) allowing users to override it with their own RateLimit parameters when they call the GetItemOffersBatch method. @abuzuhri would you be ok with either/both of these changes? Fortunately this is the only one of the hardcoded RateLimit configurations which is even close to being this restrictive.

[abuzuhri]

But user never face same issue before , ask user override is not good solution I’m thinking we can solve it in better way

…

On Wed, Jan 8, 2025 at 7:15 PM Finn Reilly ***@***.***> wrote: Hi - I've done a quick investigation into this, and it *looks* as though the ProductPricing_GetItemOffersBatch rate limit type is hardcoded with the following parameters - new RateLimits(0.1M, 1, RateLimitType.ProductPricing_GetItemOffersBatch). Unless I interpreted the RateLimits type incorrectly in my code, this means that tokens are added to the bucket at a rate of 0.1 per second with a maximum quantity (burst rate) of 1. This would appear to translate into one request being permitted every 10 seconds. @lboyarsky <https://github.com/lboyarsky> please could you confirm whether requests are being permitted at this rate? If so then potential fixes would be changing this configuration or (better) allowing users to override it with their own RateLimit parameters when they call the GetItemOffersBatch method. @abuzuhri <https://github.com/abuzuhri> would you be ok with either/both of these changes? Fortunately this is the only one of the hardcoded RateLimit configurations which is even close to being this restrictive. — Reply to this email directly, view it on GitHub <#812 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA4IEBA3OR7QLY7AQOK3TQD2JVTKPAVCNFSM6AAAAABULJDLOOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNZYGMZDGOJRGY> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[FinnReilly]

@abuzuhri can we make the configured rate limiting less restrictive than one request every 10 seconds? This seems very restrictive.

Agree re. override, would be a nice additional feature but shouldn't require the user to do it and not the biggest priority right now

I could also improve the logging to more effectively manage user expectations - eg. "next token expected in {n} milliseconds"

[abuzuhri]

I will try in week end look to the code you submitted and see where the problem first

…

On Wed, Jan 8, 2025 at 7:22 PM Finn Reilly ***@***.***> wrote: @abuzuhri <https://github.com/abuzuhri> can we make the configured rate limiting less restrictive than one request every 10 seconds? — Reply to this email directly, view it on GitHub <#812 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA4IEBBBZVENUVBJX7KIETT2JVUGTAVCNFSM6AAAAABULJDLOOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNZYGMZTOMBYG4> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[FinnReilly]

See #816 for fix + additional tests