Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to customize token name / rename token to ably-token #37

Open
sacOO7 opened this issue Jun 7, 2024 · 1 comment
Open

Ability to customize token name / rename token to ably-token #37

sacOO7 opened this issue Jun 7, 2024 · 1 comment

Comments

@sacOO7
Copy link
Collaborator

sacOO7 commented Jun 7, 2024

  • Currently, there is a popular laravel-jwt-library => jwt-auth that uses token as a default key name.
  • For a given auth request, laravel-broadcaster responds with jwt-token containing channel claims. Client resends it for next request. This is used by server to check for existing channel claims and if token can be upgraded.
  • The main issue here is token-key name sent by client in the payload. As per comment 401 Error on Subsequent Private/Public Channel Subscriptions #36 (comment), there is a need to modify this token name.
@sacOO7
Copy link
Collaborator Author

sacOO7 commented Jun 7, 2024

Current token name is token. I recommend to rename it to ably-token. There is no need to provide customization since it doesn't serve any utility as such !

@sacOO7 sacOO7 changed the title Ability to customize token name Ability to customize token name / rename token to ably-token Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant