Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request to make joyride less sensitive to bad config #26

Open
steve-tapley opened this issue Mar 27, 2015 · 3 comments
Open

request to make joyride less sensitive to bad config #26

steve-tapley opened this issue Mar 27, 2015 · 3 comments
Assignees

Comments

@steve-tapley
Copy link
Contributor

Hi,
A couple of times I've set up joyride with misconfigured config (eg a bad/mistyped element name). When the user happens to get to the step, joyride just stops working - the curtain is down, but the user has no way of recovering out of the joyride (unless they F5)

You can see this in the plunkr: http://plnkr.co/edit/Yn7cqL8IpR1VoL1ky65R

I could see this happening on a largish project where element ids change, and the tour is mistakenly not updated.

Can I make a suggestion that for misconfigured configs, that ng-joyride either end the tour, or skip the step?

Thanks,
Steve

@abhikmitra
Copy link
Owner

Makes sense. While it might be difficult to make it resilient from all sorts of bad config errors.It might make sense to skip for elements that are not present.

@abhikmitra abhikmitra self-assigned this Mar 29, 2015
@tim-stefanski
Copy link

+1 for this enhancement. Skipping a missing element rather than getting stuck would be a great feature.

@learner972
Copy link

@abhikmitra Could you please tell me how to include this as I am getting error if in case ID is not found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants