Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subscriber validators 201, 202, 300, 301, 302 do not work as expected #17

Open
pi73jyro opened this issue May 17, 2018 · 3 comments
Open

Comments

@pi73jyro
Copy link

The validation tests 201, 202, 300, 301, 302 for the subscriber do not work as I expect them to do:

  • 201/202: They publisher does not respond with a http status code of 301/302 and a http location header. Instead the publisher responds with a http status code 200.

  • 300/301/302: The test ends after a succesful subscription. No content is being delivered by the hub. There is no content notification (http post) being sent.

@euri10
Copy link

euri10 commented May 22, 2018

201 and 202 redirect in the discovery phase, see image of 202 redirecting with a 301 for instance
2018-05-22-163835_622x420_scrot

for 300+ you need to be logged in and click the Continue button and make a manual post

on a side note the registration with the email link is somewhat annoying for test automation, if that could be changed that would be cool

@pi73jyro
Copy link
Author

@euri10 I checked this again and you are right with 201 and 202. The HTTP request library I'm using automatically follows redirections for HTTP GET requests, so the redirection was "hidden" for me. My bad!

You are also right for the 300+. When I'm logged in the behaviour is as expected. But when you are not logged in, the behaviour is a bit unsatisfying.

There's nothing indicating you need to manually make a post to trigger the publisher. The green alert "Subscription activated!" makes you feel like you passed the test, even though no content was distributed.
When you click "Continue" there's still nothing saying you need to login and make a post.

01_300

02_300

It's no big deal and a simple text saying "Next Step: You need to login and make a post!" would fix this small issue.

@euri10
Copy link

euri10 commented May 23, 2018

I agree, I had to discover it as well ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants