From 9600839bd2ba0a6915908c55fca24f373c3a2106 Mon Sep 17 00:00:00 2001 From: Aaron Siddhartha Mondal Date: Fri, 27 Sep 2024 03:43:56 +0200 Subject: [PATCH] Allow nativelink flake module to upload results (#1369) --- modules/nativelink.nix | 1 - web/platform/src/content/docs/docs/nativelink-cloud/nix.mdx | 4 +--- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/modules/nativelink.nix b/modules/nativelink.nix index eb7a498b2..2173d7360 100644 --- a/modules/nativelink.nix +++ b/modules/nativelink.nix @@ -20,7 +20,6 @@ "--remote_instance_name=main" "--remote_header=x-nativelink-project=nativelink-ci" "--nogenerate_json_trace_profile" - "--remote_upload_local_results=false" "--experimental_remote_cache_async" ]; diff --git a/web/platform/src/content/docs/docs/nativelink-cloud/nix.mdx b/web/platform/src/content/docs/docs/nativelink-cloud/nix.mdx index c25fd4333..e20f634d6 100644 --- a/web/platform/src/content/docs/docs/nativelink-cloud/nix.mdx +++ b/web/platform/src/content/docs/docs/nativelink-cloud/nix.mdx @@ -12,7 +12,7 @@ artifacts from your CI builds. Cache sharing between CI and local development environments requires perfect reproducibility between the two. -Consider using [Local Remote Execution](./explanations/lre) to create +Consider using [Local Remote Execution](/docs/explanations/lre) to create environments that are reproducible across distributions. Containerized environments that are the same for local development and CI might @@ -95,7 +95,6 @@ build --remote_header=x-nativelink-api-key=065f02f53f26a12331d5cfd00a778fb243bfb build --remote_instance_name=main build --remote_header=x-nativelink-project=nativelink-ci build --nogenerate_json_trace_profile -build --remote_upload_local_results=false build --experimental_remote_cache_async ``` @@ -117,6 +116,5 @@ build:nativelink --remote_cache=grpcs://my-custom-endpoints.com build:nativelink --remote_header=x-nativelink-api-key=my-custom-readonly-api-key build:nativelink --remote_header=x-nativelink-project=nativelink-ci build:nativelink --nogenerate_json_trace_profile -build:nativelink --remote_upload_local_results=false build:nativelink --experimental_remote_cache_async ```