Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unable to handle render process crash #12

Open
jesg opened this issue Mar 29, 2018 · 1 comment
Open

unable to handle render process crash #12

jesg opened this issue Mar 29, 2018 · 1 comment
Assignees
Labels

Comments

@jesg
Copy link
Member

jesg commented Mar 29, 2018

steps:

  1. run a test
  2. crash all chrome render processes via pkill -f "chrome.*type=renderer"
  3. try to run another test

expected: next test runs successfully
actual: selenium fails with unable to connect error

notes:

  • the render process occasionally crashes in real tests
  • the parent process does not crash when the render subprocess crashes
@jesg jesg added the bug label Mar 29, 2018
@jesg jesg self-assigned this Mar 29, 2018
@jesg
Copy link
Member Author

jesg commented Mar 29, 2018

chromedriver is not complaint with the w3c spec on error handling. hence i'd have to parse the body of every response, get the status in the body, and crash the browser if it is one of the fatal statuses.

w3c would make this a lot easier because the bad failures are all 500 errors.

as long as you crash everything after each test suite it should be ok for now because the browser and agent just hang there. this is my current model when running in docker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant