Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collection not saving #333

Open
HugoKornelis opened this issue Dec 3, 2023 · 5 comments
Open

Collection not saving #333

HugoKornelis opened this issue Dec 3, 2023 · 5 comments

Comments

@HugoKornelis
Copy link

Steps to reproduce:

  1. Open, craft, or disenchant some cards
  2. Open Firestone, go to Collection tab. Watch until counters of cards per expansion are updated, ass the program synchronises its collection with the actual Hearthstone data.
  3. Close Firestone.
  4. Open Firestone again, go to Collection. See the old values of the counters of cards per expansion. (Until the program once more synchronizes with Hearthstone)

The root cause seems to be that modifications to the collection are no longer saved to %appdata%\Overwolf\lnknbakkpommmjjdnelmfbjjdbocfpnpbkijjnob\collection.json. The last modified timestamp of this file does not change anymore, and when I delete or rename it, Overwolf shows an empty collection on startup, until it synchronizes, but does not create a new collection.json file.

@sebastientromp
Copy link
Contributor

Thanks, I will look into it.

@sebastientromp
Copy link
Contributor

So it only recreates the updated collection.json if you go at least once to the Collection tab in Firestone.
This has been introduced to reduce the overhead of reading stuff from the client's memory, then storing files, if the user doesn't really use it (i.e. if they don't look at some things that need the info inside the app).

Could you try opening the collection tab, then check if the collection.json gets updated when you go to Hearthstone's Collection Manager?

@HugoKornelis
Copy link
Author

Thanks for your fast response. Here are the steps I just tried.

Open Hearthstone (HS), open FireStone (FS).
Go to collection tab in FS, go to other tab, go back to collection tab.
Go to collection manager in HS, leaf through pages. Leave collection manager open.
Switch tabs in FS, ending on collection tab.
Exit collection manager in HS. Quit HS.
Switch tabs in FS, ending on collection tab.
Close all Overwolf apps via windows toolbar (right-click Overwolf / Exit Overwolf
Restart FireStone. Check collection. It shows my old collection as of a few days ago, and not the recent changes.
Check %appdata%\Overwolf\lnknbakkpommmjjdnelmfbjjdbocfpnpbkijjnob\ folder. Last update timestamp for collection.json is still set to Dec 1, 6:17AM (CET).

Whenever FS and HS are both open, the collection tab in FS will eventually update. But it always opens with my old collection, keeps my old collection when HS is not open, and fails to update collection.json. (Which to me is rather inconvenient, because I use collection.json as input for my personal collection / missing dust tracker)

@HugoKornelis
Copy link
Author

Just to follow up, today I tried again and I noticed that collection.json does once more update when I expect it. I don't know whether this is due to something you did or due to some weird change on my end. But for now you can close this issue. (I will open a new one if it returns)

@sebastientromp
Copy link
Contributor

Thanks for the update. If the issue returns you can just reopen this one (or wait a bit before closing it, I don't use GH issues as a way to track my work, so I don't mind if things are closed in a timely manner)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants