Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

constant time comparisons #38

Open
omershlo opened this issue Mar 7, 2019 · 3 comments
Open

constant time comparisons #38

omershlo opened this issue Mar 7, 2019 · 3 comments
Assignees
@omershlo
Labels
constant time changes to make the code immune as much as possible to side channel attacks good first issue Good for newcomers

Comments

@omershlo
Copy link
Contributor

omershlo commented Mar 7, 2019

can be done using https://github.com/dalek-cryptography/subtle as one option.
Thanks to Jeremy Rubin.
@omershlo omershlo added good first issue Good for newcomers constant time changes to make the code immune as much as possible to side channel attacks labels Mar 7, 2019
@omershlo omershlo self-assigned this Mar 7, 2019
@omershlo
Copy link
Contributor Author

I started to do it in multi-party-ecdsa: https://github.com/KZen-networks/multi-party-ecdsa/blob/master/src/protocols/two_party_ecdsa/lindell_2017/party_one.rs#L562

@JeremyRubin
Copy link

That line in particular doesn't matter as the functions arguments are all public data :)

@omershlo
Copy link
Contributor Author

You are right of course, I was just excited to to test the subtle crate. I will leave it there for now to be a code reference . Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@omershlo omershlo

Labels
constant time changes to make the code immune as much as possible to side channel attacks good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JeremyRubin @omershlo