Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort out how to include zcash code #35

Open
conradoplg opened this issue May 17, 2022 · 0 comments
Open

Sort out how to include zcash code #35

conradoplg opened this issue May 17, 2022 · 0 comments

Comments

@conradoplg
Copy link
Contributor

We need to include zcash source code in order to compile and wrap it. But each strategy has downsides:

  • submodules prevents us from packaging the crate because cargo package ignores subfolders with Cargo.toml, and zcash has one in the root
  • subtree works but requires us using merge commits (which we try to avoid in our repos), since subtree relies on them to work

Come up with a better way to solve this and implement it.

Ideas:

  • Make submodules work with sparse-checkout so that we only checkout the src subfolder (which is what we need, and it does not contain a Cargo.toml
  • Find a way to automatically remove the Cargo.toml before packaging the crate
  • Something else?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant