Add option to allow building with BoringSSL #738
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nacho
force-pushed
the
wip/nacho/boringssl
branch
from
cc022aa
to
f21d41b
Compare
To build with BoringSSL CRYPTO_INCLUDE_DIRS and CRYPTO_LIBRARY_DIRS must be defined Also fix all the compile issues when building with BoringSSL
nacho
force-pushed
the
wip/nacho/boringssl
branch
from
f21d41b
to
07ecbb9
Compare
|
I went at the end for a more conservative approach given the CI failures. We can revisit it later on. Can you please approve again the run? Thanks |
|
Hi, Thank you for your patch. While we're generally not opposed to an idea like this, maintaining support for BoringSSL which has no guarantees of API stability is a fairly heavy burden. It might make more sense for us to refactor libfido2 to use a thin crypto abstraction layer that is statically linked. That would make it easier for a third party to write their own wrapper to use something else if they prefer. This has been discussed previously in the context of other crypto libraries. |
|
Sounds fair, thanks for the comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To build with BoringSSL CRYPTO_INCLUDE_DIRS
and CRYPTO_LIBRARY_DIRS must be defined
Also fix all the compile issues when building
with BoringSSL