From 7dc32f1e2d0ef48ba8eff4f546e21fffbdc27922 Mon Sep 17 00:00:00 2001
From: Ludvig Michaelsson <ludvig.michaelsson@yubico.com>
Date: Fri, 3 Nov 2023 09:44:18 +0100
Subject: [PATCH] winhello: add note about hmac-secret quirks

---
 src/winhello.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/winhello.c b/src/winhello.c
index 3fb95d58..ff969a4f 100644
--- a/src/winhello.c
+++ b/src/winhello.c
@@ -408,6 +408,10 @@ pack_cred_ext(WEBAUTHN_EXTENSIONS *out, const fido_cred_ext_t *in)
 	}
 	out->cExtensions = (DWORD)n;
 	if (in->mask & FIDO_EXT_HMAC_SECRET) {
+		/*
+		 * NOTE: webauthn.dll ignores requests to enable hmac-secret
+		 * unless a discoverable credential is also requested.
+		 */
 		if ((b = calloc(1, sizeof(*b))) == NULL) {
 			fido_log_debug("%s: calloc", __func__);
 			return -1;