Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shall we split data in separate package? #29

Open
YoungFaithful opened this issue Oct 4, 2019 · 4 comments
Open

Shall we split data in separate package? #29

YoungFaithful opened this issue Oct 4, 2019 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@YoungFaithful
Copy link
Owner

YoungFaithful commented Oct 4, 2019

  • The example data is currently provided automatically with the package
  • The data has 150 MB, the other files 4.2 MB
  • We could host the example data in a separate repository that is a julia package as well JouliaExamples
@YoungFaithful
Copy link
Owner Author

@holgerteichgraeber what do you think is the best practice?

@YoungFaithful YoungFaithful added the enhancement New feature or request label Oct 4, 2019
@holgerteichgraeber
Copy link
Collaborator

Good point. I think it would be good practice to separate the two. However, I am not sure if at this point it would make any difference. The data is already in the git history, i.e. even if we take it out, I think that the package will still be 150MB large if you clone it from git.

@holgerteichgraeber
Copy link
Collaborator

Move data to CapacityExpansionData. The git is only cloned for dev, when using it as a package, git history is not downloaded.

@YoungFaithful
Copy link
Owner Author

YoungFaithful commented Nov 1, 2019

https://github.com/YoungFaithful/CapacityExpansionData.jl/
We can continue removing the /data/ folder as soon as CapacityExpansionData is registered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants