Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v3, minor suggestion: collision between Unity.Yarn and OdinInspector attributes #279

Open
dario-zubovic opened this issue May 24, 2024 · 0 comments
Open

v3, minor suggestion: collision between Unity.Yarn and OdinInspector attributes #279

dario-zubovic opened this issue May 24, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@dario-zubovic
Copy link

What is the current behavior?
Both Yarn.Unity and Sirenix.OdinInspector namespaces define attributes named ShowIf and HideIf, causing annoying conflicts in scripts that are using both. Odin Inspector is a hugely popular Unity plugin that's used in a lot of projects, so it might make sense to avoid this collision.

Suggestion
Move classes in Attributes.cs to Yarn.Unity.Attributes or Yarn.UnityYarn.Utils namespace.

Environment:

  • Yarn Spinner Version: development/v3 (4656e24)
  • Unity Version: 2022.3.22f1
@dario-zubovic dario-zubovic added the bug Something isn't working label May 24, 2024
dario-zubovic added a commit to dario-zubovic/YarnSpinner-Unity that referenced this issue May 24, 2024
@dario-zubovic
separate attributes into their own namespace (fixes YarnSpinnerTool#279)
2500987
@dario-zubovic dario-zubovic mentioned this issue May 24, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dario-zubovic