Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update liballoc to use KernelError enum #321

Open
Kfeavel opened this issue Oct 25, 2021 · 3 comments
Open

Update liballoc to use KernelError enum #321

Kfeavel opened this issue Oct 25, 2021 · 3 comments

Comments

@Kfeavel
Copy link
Member

Kfeavel commented Oct 25, 2021

No description provided.

@Kfeavel
Copy link
Member Author

Kfeavel commented Nov 26, 2021

I think this will require use moving the libs directory from the root to the kernel directory. Not sure how else this will work, especially with SCons.

@micahswitzer
Copy link
Member

We can just add the kernel's public header directory to the CPPPATH and #include the header with the enum in it.

Alternatively we could wrap liballoc's API so that it returns a KernelError.

@Kfeavel
Copy link
Member Author

Kfeavel commented Dec 1, 2021

I was thinking about this a bit more and am still erring on the side of moving liballoc into the Kernel directory since the Libraries directory in the root normally implies it's a library that can be used in either kernel or user space. At least, it seems like that's how other projects like Serenity do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants