Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify EventPositionUncertainty plugin to work with full FDC-propagated uncertainty contours #1480

Open
juehang opened this issue Nov 17, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@juehang
Copy link
Contributor

juehang commented Nov 17, 2024

The relevant lines of code are here:

result["r_position_uncertainty"] = result["s2_r_position_uncertainty"] * scale

Currently, this plugin uses the field-distortion correction of the best-fit position to scale the uncertainties. If we propagate the entire contour using the FDC, then this would lead to an inconsistency between the contour and the r/theta uncertainties. Propagation of the contour is not an option right now, so this is not yet a problem, but this fix is a prerequisite for uncertainties to be fully propagated through the FDC correction.

@juehang juehang added enhancement New feature or request good first issue Good for newcomers labels Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants