-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Synchronization with base environment #1
Comments
The container is currently built from the development tag of the base_environment: FROM xenonnt/base-environment:development To make the MC container reproducible, we should pick a more specific tag to build from. However, base environment is currently only tagging sporadically, so I think it is better to leave it as it now, until you find a hard dependency you need to track. |
@rynge Thanks for your response and the short discussion in today's computing telecon: To continue where we left it: I fear that for us (MC team) the current most important package in the container is WFsim (CC @zhut19 @petergaemers). So I would naively assume one can just re-deploy this container as soon as there are commits on WFsim. There is for sure a better approach (also waiting for what the analysis team decided on tha base_environment), but maybe this one could work for now...? I assume there will be lots of updates and testing in the next weeks and we probably can't wait for the monthly synchronization. |
Correct - you can just redeploy your mc container when you want to include a new version of WFsim. If you want to depend on a more stable base_environment, change this line: https://github.com/XENONnT/montecarlo_environment/blob/master/Dockerfile#L1 To for example:
As you can tell, we have not tagged in while. Maybe a new tag is in order - we should check with Evan/Joran and see when tagging would be a good idea. |
Thanks Mats. There are a few things I still don't get completely, so let me see if I can bring them up properly:
(Indeed tagging versions becomes useful to solve most of the questions above :D ) |
Note that this is the approach we have currently, and I'm well aware it can be improved. So let's keep discussing! |
I forgot to mention: maybe a more formal versioning will solve this, so maybe that is the discussion we should have. |
Thanks a lot! 👍 I cc @ershockley so that he's aware of the discussion.
|
|
|
https://github.com/XENONnT/base_environment/blob/master/create-env#L89 - well that should probably be versioned like we do for straxen. To pick up this change, we can trigger new builds in DeployHQ. Once for base_environment, and when that is done, montecarlo_environment. Do you want to try to version it first, or want me to kick off the builds directly? If you do not already have a DeployHQ account and want to kick off manual builds yourself, ask Chris for an account. |
Not a problem right now, but wondering whether we want to make this automatic (is possible) at one point. I guess the solution can be not that simple, given the ROOT and G4 dependencies.
The text was updated successfully, but these errors were encountered: