Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python3 version? #13

Open
edsub opened this issue Apr 25, 2014 · 6 comments
Open

Python3 version? #13

edsub opened this issue Apr 25, 2014 · 6 comments

Comments

@edsub
Copy link

edsub commented Apr 25, 2014

Hi, I have tried to convert your code to Python3 (as I have some dataloggers running that are in Python3), but I seem to get stuck in bit where the juggling with the string/bytes/hex values takes place. (the InverterMsg.generate_string logic)

Anyone who has accompoished this allready?

@slwessels
Copy link

Hi, I'm interested in getting the same done. Did you make any progress on this?

@clmcavaney
Copy link

Righto - I think I might have got this working. I will clean up my code a little and then submit a pull request.

@LaszloBalder
Copy link

Hi, I'm interested in your python3 solution for the InverterMsg implementation, can you make it public?

thnx in advance.

@ervee
Copy link

ervee commented Jan 1, 2021

@jdgmeester
Copy link

Hi, I have tried to convert your code to Python3 (as I have some dataloggers running that are in Python3), but I seem to get stuck in bit where the juggling with the string/bytes/hex values takes place. (the InverterMsg.generate_string logic)

Anyone who has accompoished this allready?

I have exactly the same:

  • ConfigParser was renamed to configparser (change in OmnikExport.py)
  • Print requires parentheses now (change in InverterMsg.py and ConsoleOutput.py)
  • the decode feature is not accepting the hex value anymore.
    I have moved to the webbased scraper for now, but the CLI script has way more data available.

@clmcavaney
Copy link

I didn't try, but: https://github.com/clmcavaney/Omnik-Data-Logger/tree/python3-change

?

I did submit a pull request (#44) but I don't think it was merged (yet)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants