Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Dart version is at least as high as dependencies #141

Open
Levi-Lesches opened this issue Jan 8, 2025 · 0 comments
Open

Ensure Dart version is at least as high as dependencies #141

Levi-Lesches opened this issue Jan 8, 2025 · 0 comments

Comments

@Levi-Lesches
Copy link
Contributor

Levi-Lesches commented Jan 8, 2025

Say I have the following project:

environment:
  sdk: ^3.0.0

dependencies:
  pubspec_parse: ^1.5.0

This compiles, Pub doesn't complain, and this tool validates it with no issues. However, pubspec_parse version 1.5 requires Dart 3.6! Everything works because, coincidentally, I happen to have Dart 3.6 on my PC. But someone else might not, especially a CI workflow (this just happened in #138 but it happens to me all the time). I have a use case where I need to be entirely offline, so I'd like to know if I need to upgrade my Dart SDK as far in advance as possible.

To handle this, the tool should notice that pubspec_parse requires Dart 3.6 and flag that my environment.sdk is less than that. To handle the transitive case as well, the tool can look through .dart_tool/package_config.json and use the highest languageVersion it finds.


I filed dart-lang/pub#4488 to see if the Dart team wants to integrate this into Pub directly as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant