Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimum PHP version bump #791

Closed
ernilambar opened this issue Nov 18, 2024 · 0 comments · Fixed by #796
Closed

Minimum PHP version bump #791

ernilambar opened this issue Nov 18, 2024 · 0 comments · Fixed by #796
Labels
Infrastructure Issues for the overall plugin infrastructure

Comments

@ernilambar
Copy link
Member

Current: 7.2

Sparked from #789

I am working on updating the readme parser to use its latest version. That class is coming from WP.org and its minimum PHP support is 7.4. So we are now stuck the older version of the readme parser in our plugin.

I created ticket in meta about the issue but it did not get traction to make parser class to make PHP 7.2 compatible - https://meta.trac.wordpress.org/ticket/7749

So, may be we could bump our min PHP version instead of using composer patch for the parser.

I have not seen the discussion about minimum PHP version support in PCP particularly. What philosophy we are following for the minimum PHP version support?

@ernilambar ernilambar added the Infrastructure Issues for the overall plugin infrastructure label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Issues for the overall plugin infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant