Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Health tests for images should be moved to the Modern Image Formats plugin #1781

Open
westonruter opened this issue Jan 7, 2025 · 4 comments
Labels
[Plugin] Modern Image Formats Issues for the Modern Image Formats plugin (formerly WebP Uploads) [Plugin] Performance Lab Issue relates to work in the Performance Lab Plugin only [Type] Enhancement A suggestion for improvement of an existing feature

Comments

@westonruter
Copy link
Member

Feature Description

There are five Site Health tests currently:

  1. audit-autoloaded-options
  2. audit-enqueued-assets
  3. avif-headers
  4. avif-support
  5. webp-support

The first two would remain in Performance Lab since they aren't related to any other plugins. But the last three would make sense to move to the Modern Image Formats plugin at some point. Otherwise, someone could install the Modern Image Formats plugin alone without Performance Lab and then miss out on those Site Health tests which would be dependencies for the plugin working properly.

Previously discussed at #1731 (comment)

@westonruter westonruter added [Plugin] Modern Image Formats Issues for the Modern Image Formats plugin (formerly WebP Uploads) [Plugin] Performance Lab Issue relates to work in the Performance Lab Plugin only [Type] Enhancement A suggestion for improvement of an existing feature labels Jan 7, 2025
@github-project-automation github-project-automation bot moved this to Not Started/Backlog 📆 in WP Performance 2024 Jan 7, 2025
@joemcgill
Copy link
Member

For background, part of the logic for keeping all the Site Health checks in the main Performance Lab plugin was so that folks running Performance Lab (which is the larger user base) would get feedback about ways they could improve the performance of their site, including being able to encourage feature plugins from the Performance Team, when applicable.

This also separates health checks that surface things that can be improved, from specific implementations, while allowing the Performance Team plugins to customize those health checks via filters.

I think there is still value in keeping these separate from the plugins that they're related to, personally.

@westonruter
Copy link
Member Author

Regarding these tests specifically:

These don't really matter on sites that don't have the Modern Image Formats plugin active, do they?

@joemcgill
Copy link
Member

That's probably true for avif-headers, but the two health checks for server support of WebP and AVIF are useful regardless of whether you are using our plugins to produce WebP or not.

That said, those two base health checks should probably be in Core already, since both formats are supported in Core today. What do you think?

@westonruter
Copy link
Member Author

Yeah, they all three seem relevant for core now actually. Maybe there should be a webp-headers test as well to go alongside avif-headers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Plugin] Modern Image Formats Issues for the Modern Image Formats plugin (formerly WebP Uploads) [Plugin] Performance Lab Issue relates to work in the Performance Lab Plugin only [Type] Enhancement A suggestion for improvement of an existing feature
Projects
Status: Not Started/Backlog 📆
Development

No branches or pull requests

2 participants